search

uclaacm / opensource

opensource @ acm, work-in-progress
https://opensource.uclaacm.com
MIT License
11 stars 6 forks source link

feat: implement search highlight #205

Closed ansh-saini closed 1 month ago

ansh-saini commented 1 month ago

Fixes #96

I'm using the browser built-in mark tag to achieve the highlight. This will ensure standard behaviour on all operating systems.

Here's a screenshot of how it looks: image

ansh-saini commented 1 month ago

@snigdha-kansal Review please? :)

ansh-saini commented 1 month ago

@snigdha-kansal Did you get a chance to review this?

ansh-saini commented 1 month ago

Thank you for the review @snigdha-kansal You found a great bug! I've fixed it.

snigdha-kansal commented 1 month ago

@ansh-saini It looks great, thanks! One last thing: Can we remove match support for if user enters just a single spacebar?

image
ansh-saini commented 1 month ago

Another great find @snigdha-kansal. Thanks, I've resolved it.

ansh-saini commented 1 month ago

Hey @snigdha-kansal Thank you for the approval. Can you please also add the hacktoberfest-accepted label on this PR?

Also, just curious as to why you've approved this PR but not merged it. Is there something blocking the merge?

snigdha-kansal commented 1 month ago

@ansh-saini just added the label oh i just thought you will like to merge it 😂 i can merge!