uclaacm / website

The official (award-winning) website for ACM at UCLA, the largest tech community on campus!

https://acm.cs.ucla.edu

Mozilla Public License 2.0

18 stars 20 forks source link

Officers page #678

Closed larryz1230 closed 7 months ago

larryz1230 commented 8 months ago

Changes

Created a new officer parsing script officer-parser.mjs
- can be run using npm run ofp, writes ACM directory data to offoutput.json
- responsive to mobile views
Added a new officers page to the navbar
- Now /officers redirects to the Officers page
- displays data from offoutput.json including images
- images that are null or cannot be found are replaced with a default profile pic

Note: Google Drive images should be public to all, not just to UCLA emails

Code

Used committees.scss for styling as the two pages are very similar
Check for any Google updates to image format, as previous version might have been deprecated: https://issuetracker.google.com/issues/229184403

Testing

Tested using data from the 2023-2024 ACM Directory: https://docs.google.com/spreadsheets/d/1EU-Fx5DlvRV91_prtY1NQXB7XvjvjSQ2xcdZcICV8PQ/edit#gid=0

Case 1

Desktop View:

Case 2

Mobile View:

larryz1230 commented 8 months ago

Arshhh the linting passed on my device idk why it doesn't pass here

ArshMalik02 commented 8 months ago

@larryz1230 check out this fix that was implemented by Amy to resolve the URL sanitization issue. https://github.com/uclaacm/website/pull/658

Specifically, look at this and the following commits: https://github.com/uclaacm/website/pull/658/commits/88394cd704f4ff02b7af7f850f88d20211e32fbf

larryz1230 commented 8 months ago

@ArshMalik02 Added changes pls check again :))