ucladevx / Bruin-Bite-iOS

Mozilla Public License 2.0
8 stars 1 forks source link

Enable multiline chat (& other chat improvements) #107

Closed pluscubed closed 5 years ago

pluscubed commented 5 years ago

Resolves #98.

Multi-line chat bubbles and input are both working. Tested on iPhone 8 and iPhone XR simulator.

Technical changes made: allow multi-line chat UILabels, change constraints to depend on table cell boundaries, change UITextField to UITextView for multi-line input (with a grey border using a UIView extension configurable in Storyboard), move table/input into a StackView for expandable input and easier keyboard constraint animation

The only new issue is that the placeholder text is gone, due to using UITextView instead of UITextField. There are workarounds, but IMO it looks fine (and it's the default look in Messages anyway).

simulator screen shot - iphone xr - 2019-03-03 at 18 46 46

pluscubed commented 5 years ago

Fixed 2 existing issues:

pluscubed commented 5 years ago

Fixed 1 more existing issue:

pluscubed commented 5 years ago

Fixed a new issue due to multiline UILabels not playing well with insets.

Also set the chat screen's navbar title to the other person's first name.

kamalca commented 5 years ago

Looks good!