search

ucladevx / Bruin-Bite-iOS

Mozilla Public License 2.0
8 stars 1 forks source link

Add a Logger class to centralize Log Management #95

Open kamalca opened 6 years ago

kamalca commented 6 years ago

All print statements now use a centralized class to report errors, warnings, and other information.

screen shot 2018-09-01 at 4 23 38 pm

Note: Some messaged from pods or from UI elements still do not use the error class because I did not want to edit any of the locked files that are in charge of printing these messages.

I did my best to clean up the error reporting so that any error could be traced back to the code that produced them.

As for reporting what view controller they came from, the error itself should be good enough to track which code the error came from. However, something that I I looked into and may be useful is reporting which ViewController is open when the error was reported. This feature could be added upon request.

HirdayGupta commented 6 years ago

@kamalca When there are many requested changes, Github hides some of the requested changes by default, so be sure to click the show hidden button to get every requested change! Also feel free to comment on any of the review comments to start a discussion about the changes requested if you feel you didn't understand a requested change or do not agree.

HirdayGupta commented 5 years ago

@kamalca Any progress on this Pull Request?