search

uclahs-cds / Ligare

GNU General Public License v2.0
0 stars 0 forks source link

Add Feature Flags module to Ligare.web and Ligare.platform #107

Closed aholmes closed 3 weeks ago

aholmes commented 1 month ago

This PR contains refactors and feature additions to support adding a DI module to Ligare.platform that can handle the logic needed for Feature Flag usage, and the addition of an ASGI module to support a Feature Flag GET/PATCH API in Ligare.web.

aholmes commented 3 weeks ago

LGTM from a code perspective. Changes seem to stay within existing patterns, so I'm trusting the tests here. I may have some design suggestions once I start using this with a real application, but I don't feel there's too much I can comment on until then.

I'm resolving some scaffolding bugs, but once those are complete we can use the scaffolded applications as reference implementations. Should make it easier to go off of than relying on CAP, since that mixes in a bunch of domain concerns as well.