search

uclahs-cds / Ligare

GNU General Public License v2.0
0 stars 0 forks source link

Added classes to deal with ASGI library limitations. #68

Closed aholmes closed 5 months ago

aholmes commented 5 months ago

The recommended way of hosting an asgi application (using gunicorn with an uvicorn worker) causes this error https://github.com/encode/starlette/discussions/2408 in some middleware.

The recommended way to run the asgi application does not contain key command-line arguments needed to make some ASGI applications work, notably when the application is behind nginx.

The undocumented way to gain the needed cli arguments is to extend the existing UvicornWorker classes. This PR resolves that. https://github.com/encode/uvicorn/issues/343

This PR also resolves a crash when the HTTP request client variable is None.