search

uclahs-cds / metapipeline-DNA

Nextflow pipeline to convert BAM to FASTQ, align, perform QC, assess targeted coverage, call gSNP, call sSNV, call mtSNV, call SVs, call sCNA, and perform subclonal reconstruction
GNU General Public License v2.0
4 stars 0 forks source link

Allow choice of sample when running multi-tumor patients in paired mode with a single normal #149

Open yashpatel6 opened 9 months ago

yashpatel6 commented 9 months ago 
          > The deletion doesn't actually change any behavior at all in the metapipeline; the metapipeline already greedily takes the first normal BAM and uses it while ignoring the others when running multi-tumor patients in paired mode. Also, the deletion is only happening under /scratch, the final output directory still contains all of the normal BAMs generated in their respective output directories.

The change here is purely to clean up /scratch by removing files that are already not being used further in the metapipeline

Got it. End users might want to rerun somatic pipelines retrospectively if the specific normal sample has potential issues, especially when the normal processed with mets samples was used while primary one is available. It would be useful to eventually have an option to choose which normal sample to use.

Originally posted by @tyamaguchi-ucla in https://github.com/uclahs-cds/metapipeline-DNA/issues/139#issuecomment-1823547007

yashpatel6 commented 9 months ago 
          Agreed, I figure it hasn't been a huge issue so far since this only applies when run with a specific combination of samples and run mode; if multi-tumor samples are run in multi mode or if the normal-tumor samples are explicitly paired and then run in paired mode, this behavior should have no effect. I'll add an issue for allowing users to choose for that specific case though!

Originally posted by @yashpatel6 in https://github.com/uclahs-cds/metapipeline-DNA/issues/139#issuecomment-1823552318