whelena
commented
3 days ago Fixed issue 1 by adding a for loop.
All the force pushed is because I messed up and branched off the danknight-scalebar branch instead of main. Should be good now!
Open whelena opened 3 days ago
whelena
commented
3 days ago Fixed issue 1 by adding a for loop.
All the force pushed is because I messed up and branched off the danknight-scalebar branch instead of main. Should be good now!
whelena
commented
3 days ago Fixed issue 2 by considering mode when adding text. The fix improves readability in dendrogram mode without affecting `radial mode
Description
Fixing 2 main issues:
The first problem is due to a missing segment from the old (pre-plyr) version, where line 517-546 is missing
Closes #139
Checklist
[ ] This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
Disclosing PHI is a major problem[^1] - Even a small leak can be costly[^2].
[ ] This PR does NOT contain germline genetic data[^3], RNA-Seq, DNA methylation, microbiome or other molecular data[^4].
[^1]: UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records [^2]: The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records. [^3]: Genetic information is considered PHI. Forensic assays can identify patients with as few as 21 SNPs [^4]: RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity.
.png, .jpeg),.pdf,.RData,.xlsx,.doc,.ppt, or other output files.To automatically exclude such files using a .gitignore file, see here for example.
[ ] I have read the code review guidelines and the code review best practice on GitHub check-list.
[ ] I have set up or verified the
mainbranch protection rule following the github standards before opening this pull request.[ ] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
[ ] I have added the major changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.