[X] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].
[X] I have set up or verified the branch protection rule following the github standards before opening this pull request.
[X] I have added the changes included in this pull request to NEWS under the next release version or unreleased, and updated the date.
[X] I have updated the version number in metadata.yaml and DESCRIPTION.
[X] Both R CMD build and R CMD check run successfully.
These changes set the default branch angle value as pi / 6. This has been a sensible value, and complex plots can be made without changing this. If a plot does not work with this value, it will likely need more granular branch angle control (not just a different value for fixed_angle. For this reason, I removed the argument from SRCGrob and added a check for an angle column in the input tree data.frame.
The angle column is not implemented yet, but it will not require any changes to the API. It can be included in the documentation. Until it is fully implemented, a message will be displayed if it is included in the input.
[X] I have read the code review guidelines and the code review best practice on GitHub check-list.
[X] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].
[X] I have set up or verified the branch protection rule following the github standards before opening this pull request.
[X] I have added the changes included in this pull request to
NEWSunder the next release version or unreleased, and updated the date.[X] I have updated the version number in
metadata.yamlandDESCRIPTION.[X] Both
R CMD buildandR CMD checkrun successfully.These changes set the default branch angle value as
pi / 6. This has been a sensible value, and complex plots can be made without changing this. If a plot does not work with this value, it will likely need more granular branch angle control (not just a different value forfixed_angle. For this reason, I removed the argument fromSRCGroband added a check for ananglecolumn in the input tree data.frame.The
anglecolumn is not implemented yet, but it will not require any changes to the API. It can be included in the documentation. Until it is fully implemented, a message will be displayed if it is included in the input.