search

uclahs-cds / package-CancerEvolutionVisualization

Publication Quality Phylogenetic Tree Plots
https://cran.r-project.org/web/packages/CancerEvolutionVisualization/
GNU General Public License v2.0
2 stars 0 forks source link

Simplify output format #27

Closed dan-knight closed 2 years ago

dan-knight commented 2 years ago

These changes remove the list that included calculated clone.out values from the return value of SRCGrob, only returning the plot gTree object itself.

whelena commented 2 years ago

Why do we want to remove clone.out again? Is the info stored in clone.out reflected in out.tree and so we don't need both?

dan-knight commented 2 years ago

Why do we want to remove clone.out again?

This is essentially a copy of the environment used to create the tree plot. It seems that this was used to debug output during development, but that can be done with a debugger/breakpoints. The function should really just return the plot.

whelena commented 2 years ago

Why do we want to remove clone.out again?

This is essentially a copy of the environment used to create the tree plot. It seems that this was used to debug output during development, but that can be done with a debugger/breakpoints. The function should really just return the plot.

makes sense, cool