[X] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].
[X] I have set up or verified the branch protection rule following the github standards before opening this pull request.
[X] I have added the changes included in this pull request to NEWS under the next release version or unreleased, and updated the date.
[X] I have updated the version number in metadata.yaml and DESCRIPTION.
[x] Both R CMD build and R CMD check run successfully.
Added functions for deep comparison of the values in plot Grobs. The tests were also changed to utilize this comparison. Some minor changes to the plotting functions were needed to make testing more consistent (mainly naming the Grobs within the plot for easier lookup).
Testing Results
All old and new test cases pass. The new test case compares a saved plot to a newly generated plot (with slight differences in position allowed).
[X] I have read the code review guidelines and the code review best practice on GitHub check-list.
[X] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].
[X] I have set up or verified the branch protection rule following the github standards before opening this pull request.
[X] I have added the changes included in this pull request to
NEWSunder the next release version or unreleased, and updated the date.[X] I have updated the version number in
metadata.yamlandDESCRIPTION.[x] Both
R CMD buildandR CMD checkrun successfully.Added functions for deep comparison of the values in plot Grobs. The tests were also changed to utilize this comparison. Some minor changes to the plotting functions were needed to make testing more consistent (mainly naming the Grobs within the plot for easier lookup).
Testing Results
All old and new test cases pass. The new test case compares a saved plot to a newly generated plot (with slight differences in position allowed).