Removed the filename parameter from SRCGrob. This hasn't actually been connected to any kind of file export method, so there's no loss of functionality.
Since this function creates a grob, it should following grid patterns for use. These grobs already have specific patterns for use (grid.draw(grob), etc.) so I don't think that side effects like file exports should be built into this function. I think that a the best approach is to allow users to handle this as they would normally handle grobs. For example, they might be used to using their IDE to export plots.
This functionality should be added later when larger reports are generated. A separate utility function can be included to export SRCGrob objects themselves, but I don't think it belongs in SRCGrob.
Removed the
filenameparameter fromSRCGrob. This hasn't actually been connected to any kind of file export method, so there's no loss of functionality.Since this function creates a grob, it should following grid patterns for use. These grobs already have specific patterns for use (
grid.draw(grob), etc.) so I don't think that side effects like file exports should be built into this function. I think that a the best approach is to allow users to handle this as they would normally handle grobs. For example, they might be used to using their IDE to export plots.This functionality should be added later when larger reports are generated. A separate utility function can be included to export
SRCGrobobjects themselves, but I don't think it belongs inSRCGrob.