uclahs-cds / package-CancerEvolutionVisualization

Publication Quality Phylogenetic Tree Plots
https://cran.r-project.org/web/packages/CancerEvolutionVisualization/
GNU General Public License v2.0
2 stars 0 forks source link

Fix globals in heatmap functions #71

Closed dan-knight closed 1 year ago

dan-knight commented 1 year ago

Description

These changes fix the Undefined global functions or variables R CMD check NOTE, as well as inevitable runtime errors. Some of these helper functions should be refactored or reimplemented, but this is beyond the scope of these fixes.

Checklist

dan-knight commented 1 year ago

everything looks good, seems like the get.colours and data.frame.to.matrix are still the original? either way it looks like it would do what it needs to

Just renamed and maybe slightly simplified. No real changes from yours. I didn't want to include any real functional changes here, just enough to fix the problems in R CMD check.