uclahs-cds / package-CancerEvolutionVisualization

Publication Quality Phylogenetic Tree Plots

https://cran.r-project.org/web/packages/CancerEvolutionVisualization/

GNU General Public License v2.0

2 stars 0 forks source link

Refactor heatmaps #73

Open dan-knight opened 1 year ago

dan-knight commented 1 year ago

Description

Closes #...

Checklist

[ ] This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
[ ] This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
[ ] I have read the code review guidelines and the code review best practice on GitHub check-list.
[ ] I have set up or verified the main branch protection rule following the github standards before opening this pull request.
[ ] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
[ ] I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Pipeline Run Results

Case 1
- sample:
- input csv:
- config:
- output:
- log:
Case 2
- sample:
- input csv:
- config:
- output:
- log:

Analysis Results

Case 1
- script:
- command:
- output:
Case 2
- script:
- command:
- output:

dan-knight commented 8 months ago

EDIT: Addressed separately in #108

These functions are being picked up as S3 methods for the built-in plot function (which, of course, they aren't). This is just a naming conflict, so I can just change the names to follow BPG'screate.<plot type> standard.