uclahs-cds / package-iSubGen

GNU General Public License v2.0
1 stars 0 forks source link

Issue fixes for data.frame check and file check #5

Closed maotian06 closed 3 weeks ago

maotian06 commented 1 year ago

Description

Fixed two bugs related to R version changes:

  1. add a check for data.frame which is appended to the check for matrix.
  2. change exists() function to file.exists() function.

Checklist

tyamaguchi-ucla commented 1 year ago

@maotian06 I made you an admin for this repo. You should be able to add branch protection rules.

tyamaguchi-ucla commented 3 weeks ago

@maotian06 Also, as you've changed multiple if blocks, if you haven't, this PR needs to be tested to confirm that no issues were introduced.

jarbet commented 3 weeks ago

Looks generally good to me. I've added one minor comment. Anything else to add @jarbet?

We should be good to go as long as the test cases work without any issues.

The PR LGTM. However, I cannot get the README examples to work on my Mac or cluster. It would be good for someone to confirm that these work.

When trying to run them on my Mac, it crashes.

I'm trying to get it to work on the cluster with the R module, but I need to install python. Maybe it would be good to create some instructions for how to successfully install iSubGen? @tyamaguchi-ucla - do the README examples work for you?