Closed maotian06 closed 3 weeks ago
@maotian06 I made you an admin for this repo. You should be able to add branch protection rules.
@maotian06 Also, as you've changed multiple if blocks, if you haven't, this PR needs to be tested to confirm that no issues were introduced.
Looks generally good to me. I've added one minor comment. Anything else to add @jarbet?
We should be good to go as long as the test cases work without any issues.
The PR LGTM. However, I cannot get the README examples to work on my Mac or cluster. It would be good for someone to confirm that these work.
When trying to run them on my Mac, it crashes.
I'm trying to get it to work on the cluster with the R module, but I need to install python. Maybe it would be good to create some instructions for how to successfully install iSubGen
? @tyamaguchi-ucla - do the README examples work for you?
Description
Fixed two bugs related to R version changes:
data.frame
which is appended to the check formatrix
.exists()
function tofile.exists()
function.Checklist
.png
, .jpeg
),.pdf
,.RData
,.xlsx
,.doc
,.ppt
, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.main
branch protection rule following the github standards before opening this pull request.CHANGELOG.md
under the next release version or unreleased, and updated the date.