yashpatel6 commented 8 months ago

Description

Releasing 10.0.0-rc.1 since several changes have accumulated and a required parameter has been added

Checklist

[X] I have read the code review guidelines and the code review best practice on GitHub check-list.
[X] I have reviewed the Nextflow pipeline standards.
[X] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
[X] I have set up the branch protection rule following the github standards before opening this pull request, or the branch protection rule has already been set up.
[X] I have added my name to the contributors listings in the manifest block in the nextflow.config as part of this pull request, am listed already, or do not wish to be listed. (This acknowledgement is optional.)
[X] I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
[X] I have updated the version number in the metadata.yaml and manifest block of the nextflow.config file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)
[ ] I have tested the pipeline on at least one A-mini sample with aligner setting to BWA-MEM2, HISAT2, and both. The paths to the test config files and output directories were attached in the Testing Results section.

aholmes commented 8 months ago

Release candidate number should not have a period in it.

yashpatel6 commented 8 months ago

Is that according to semver? They seem to include a period. ex. https://semver.org/spec/v2.0.0-rc.1.html