Closed lydiayliu closed 1 year ago
The split fasta files are filtered as long as you have the filterFasta
namespace in the config file.
But why don't we rename the split filtered fastas from the unfiltered ones? This was my thing in #64 as well, where samples that don't have expression table still output unfiltered split fastas, that are the same name as the samples with expression table and thus have filtered split fastas
Should there be a merged_peptides_summary.txt
?
But why don't we rename the split filtered fastas from the unfiltered ones? This was my thing in https://github.com/uclahs-cds/pipeline-call-NonCanonicalPeptide/issues/64 as well, where samples that don't have expression table still output unfiltered split fastas, that are the same name as the samples with expression table and thus have filtered split fastas
That makes sense. Sorry I missed #64! I can add a label of filtered/split/splitFiltered/merged/mergedFiltered. Will we have variant peptide filtered but not noncoding peptides?
merged_peptides_summary.txt
Sounds good!
i think something like a split_filtered
directory could be great!
If the user didn't input noncoding peptides then there won't be any filtered ones.
It would be great if you could add this and I'll test it out on CCLE again! I think this is the most complicated way I've tried to run this pipeline so far, I use to do the splitting, and spliting + filtering in separate runs
I like that idea. It makes it a little easier.
So I'm trying to do as many things in a meta pipeline run as possible, here is the config specific to callNoncanonical
You can see that I want to do 3 things
Here's an example output sample. The GVFs are fine, and the variant and merged fasta files are fine with the summary files
But in the
split
directory, I just gotAre these split files filtered or un-filtered? Also, should there be a
merged_peptides_summary.txt
?Also I think in many ways this is related to #64