Closed Faizal-Eeman closed 7 months ago
@Faizal-Eeman The diagram in the README can be replaced with the updated one
@Faizal-Eeman The diagram in the README can be replaced with the updated one
Yup, done. I think this PR ready. @yashpatel6
A couple of comments:
A VScode extension seems to be auto-introducing changes whenever I save a file. The broken links were a cause of that and were not supposed to be there anyway.
I've fixed the README file for now.
Description
Add PlantUML diagram.
Closes #125
Testing Results
Checklist
[x] I have read the code review guidelines and the code review best practice on GitHub check-list.
[x] I have reviewed the Nextflow pipeline standards.
[x] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
[x] I have set up or verified the branch protection rule following the github standards before opening this pull request.
[x] I have added my name to the contributors listings in the
manifest
block in thenextflow.config
as part of this pull request, am listed already, or do not wish to be listed. (This acknowledgement is optional.)[ ] I have added the changes included in this pull request to the
CHANGELOG.md
under the next release version or unreleased, and updated the date.[x] I have updated the version number in the
metadata.yaml
andmanifest
block of thenextflow.config
file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)[ ] I have tested the pipeline on at least one A-mini sample with
run_delly = true
,run_manta = true
,run_qc = true
. Forrun_delly = true
, I have tested 'variant_type' set togSV
,gCNV
, and both. The paths to the test config files and output directories are captured above in the Testing Results section.