Closed Faizal-Eeman closed 5 months ago
Bleep bloop, I am a robot.
Alas, some of the Nextflow configuration tests failed!
@ ["params","proc_resource_params","call_gSV_Manta","cpus"]
- "1"
+ "6"
@ ["process","withName:call_gSV_Manta","cpus"]
- "1"
+ "6"
If the above changes are surprising, stop and determine what happened.
If the above changes are expected, there are two ways to fix this:
/fix-tests
Bleep bloop, I am a robot.
I have updated all of the failing tests for you with 4b7584bd8c6c8f01ff0891ffbb1d34d888567a33. You must review my work before merging this pull request!
Any reason to only update the F16 and F32 configs and not the rest?
@yashpatel6
Description
Increment CPU allocation for Manta.
The increments in this PR were primarily adapted from pipeline-call-sSNV and tailored to pipeline-call-gSV's requirements.
Closes #154
Testing Results
output dir:
/hot/software/pipeline/pipeline-call-gSV/Nextflow/development/unreleased/mmootor-optimize-manta-cpu/
Checklist
[x] I have read the code review guidelines and the code review best practice on GitHub check-list.
[x] I have reviewed the Nextflow pipeline standards.
[x] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
[x] I have set up or verified the branch protection rule following the github standards before opening this pull request.
[x] I have added my name to the contributors listings in the
manifest
block in thenextflow.config
as part of this pull request, am listed already, or do not wish to be listed. (This acknowledgement is optional.)[x] I have added the changes included in this pull request to the
CHANGELOG.md
under the next release version or unreleased, and updated the date.[x] I have updated the version number in the
metadata.yaml
andmanifest
block of thenextflow.config
file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)[x] I have tested the pipeline on at least one A-mini sample with
run_delly = true
,run_manta = true
,run_qc = true
. Forrun_delly = true
, I have tested 'variant_type' set togSV
,gCNV
, and both. The paths to the test config files and output directories are captured above in the Testing Results section.