nwiltsie
commented
7 months ago It may be worth making the regression test(s) a required passing check before merging PRs similar to how we have CI/CD set
Yeah, we'll need to work out the best way of doing that - the job names are somewhat dynamic, as they match the test files on disk, so tracking all of them is a moving target. Maybe we can add a summary "all tests passed" check to the Action and then depend upon that.
Description
This PR adds in the new Nextflow configuration regression test Action from https://github.com/uclahs-cds/tool-Nextflow-action/pull/16, as well as two regression tests. (This is the formal version of #52.)
I specifically make no claims that the values shown in the tests are what we intend - I only claim that they match the current outputs of the configuration process.
Testing Results
As these are infrastructure-only changes, there are no changes to the pipeline itself and thus no need to run other tests.
Checklist
[x] I have read the code review guidelines and the code review best practice on GitHub check-list.
[x] I have reviewed the Nextflow pipeline standards.
[x] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
[x] I have set up or verified the branch protection rule following the github standards before opening this pull request.
[x] I have added my name to the contributors listings in the
manifestblock in thenextflow.configas part of this pull request, am listed already, or do not wish to be listed. (This acknowledgement is optional.)[x] I have added the changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.[ ] I have updated the version number in the
metadata.yamlandmanifestblock of thenextflow.configfile following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)[x] I have tested the pipeline using NFTest, or I have justified why I did not need to run NFTest above.