search

uclahs-cds / tool-Docker-action

GNU General Public License v2.0
0 stars 0 forks source link

Handle non-SemVer tags appropriately #17

Closed nwiltsie closed 3 weeks ago

nwiltsie commented 1 month ago

https://github.com/uclahs-cds/docker-BCFtools-score contains multiple tools, so its tagged versions look like v1.20_score-1.20-20240505. Unfortunately with #14 I leaned in to the SemVer styling, so the metadata action throws a fit over that non-standard tag:

Warning: v1.20_score-1.20-20240505 is not a valid semver. More info: https://semver.org/
Warning: No Docker image version has been generated. Check tags input.
Warning: No Docker tag has been generated. Check tags input.

ERROR: tag is needed when pushing to registry

We should be able to handle that case.

nwiltsie commented 1 month ago

Until I manage to get an appropriate global fix for this, individual repositories can work around this issue by passing custom-tags:

jobs:
  push-or-delete-image:
    runs-on: ubuntu-latest
    name: Update GitHub Container Registry
    permissions:
      contents: read
      packages: write
    steps:
      - uses: uclahs-cds/tool-Docker-action@v2.0.0
        with:
          custom-tags: |
            type=match,pattern=v(.*),group=1
nwiltsie commented 3 weeks ago

Closed by #18.