search

uclahs-cds / tool-NFTest

CLI to automate Nextflow pipeline testing
GNU General Public License v2.0
11 stars 1 forks source link

Dependency injection for logger #28

Open yashpatel6 opened 2 years ago

yashpatel6 commented 2 years ago 
    Disabling the warning works, but it may be a code smell. Have you considered refactoring `__init__` to use dependency injection for the logger?

_Originally posted by @dan-knight in https://github.com/uclahs-cds/tool-NF-test/pull/27#discussion_r1035342153_

dan-knight commented 2 years ago

This will mean that the private _logger attribute won't be accessed directly, so the pylint warnings will go away. If we make this change, be sure to also remove the relevant pylint: disable comments from unit tests.