Oof, I'm almost certain this one is my doing 🤦♂️.
Right now the check for whether or not a test has failed always passes, as we're checking the truthiness of the CompletedProcess. This change makes it so that we properly examine the exit code:
#!/usr/bin/env python3
import subprocess
# How we're running Nextflow under the hood
with subprocess.Popen(["false"]) as process:
pass
print("The current test... ", end="")
if not process:
print("correctly caught the failure")
else:
print("FAILED")
print("The updated test... ", end="")
if process.returncode != 0:
print("correctly caught the failure")
else:
print("FAILED")
$ python3 tester.py
The current test... FAILED
The updated test... correctly caught the failure
Checklist
[x] This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem[^1] - Even a small leak can be costly[^2].
[x] This PR does NOT contain germline genetic data[^3], RNA-Seq, DNA methylation, microbiome or other molecular data[^4].
[x] This PR does NOT contain other non-plain text files, such as: compressed files, images (e.g..png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other output files.
To automatically exclude such files using a .gitignore file, see here for example.
[x] I have set up or verified the main branch protection rule following the github standards before opening this pull request.
[x] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
[x] I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
Description
Oof, I'm almost certain this one is my doing 🤦♂️.
Right now the check for whether or not a test has failed always passes, as we're checking the truthiness of the
CompletedProcess. This change makes it so that we properly examine the exit code:Checklist
[x] This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
Disclosing PHI is a major problem[^1] - Even a small leak can be costly[^2].
[x] This PR does NOT contain germline genetic data[^3], RNA-Seq, DNA methylation, microbiome or other molecular data[^4].
[^1]: UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records [^2]: The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records. [^3]: Genetic information is considered PHI. Forensic assays can identify patients with as few as 21 SNPs [^4]: RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity.
.png, .jpeg),.pdf,.RData,.xlsx,.doc,.ppt, or other output files.To automatically exclude such files using a .gitignore file, see here for example.
[x] I have read the code review guidelines and the code review best practice on GitHub check-list.
[x] I have set up or verified the
mainbranch protection rule following the github standards before opening this pull request.[x] The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
[x] I have added the major changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.