uclaradio / uclaradio.com

UCLA Radio Website

http://www.uclaradio.com

GNU Affero General Public License v3.0

31 stars 4 forks source link

Changed pagination index to be 1-indexed #322

Closed arjunr00 closed 5 years ago

arjunr00 commented 5 years ago

Types of changes

[x] Bugfix (change which fixes an issue)
[ ] New feature (change which adds functionality)
[ ] Refactor (change which changes the codebase without affecting its external behavior)
[x] Non-breaking change (fix or feature that would causes existing functionality to work as expected)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

Before, blogpost pagination was indexed at 0. That is not intuitive for anyone but those with some experience with CS, so this PR changes indexing to start at 1.

Screenshot(s)

Before	After

Checklist

[x] My branch follows the branch naming scheme of UCLA Radio, and can merge into master without error.
[x] My code follows the code style of this project, and I have linted it to confirm this.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] My change requires a change to the documentation and I have updated the documentation accordingly.
[x] All new and existing tests passed.

Link to Issue

321