search

ucldc / public_interface

Calisphere public interface source code (UCLDC Project) master branch should match live site
https://calisphere.org/
2 stars 5 forks source link

7. Media #292

Closed amywieliczka closed 7 months ago

amywieliczka commented 8 months ago

This attempts to create an abstraction layer for the Solr side of things and only includes some marginal level of Rikolti adaptation - see #295 for a more complete Rikolti adaptation of media handling

barbarahui commented 7 months ago

@amywieliczka I looked through the 7 PRs that culmulatively end with this one. PRs 1-6 look good to me. Your approach here also makes a lot of sense to me.

I just added a couple of 1-line code suggestions to calisphere/record.py that reflect some work I did that isn't incorporated here. (I know this is a draft; just didn't want it to get lost):

  1. The existence of media isn't a reliable indicator of whether or not a record is hosted; some complex objects don't have media at the parent level.
  2. The iiif_url now needs to be url encoded as we are storing files on s3 by filename, not md5 hash. Some of the filenames contain special characters.