ucldc / public_interface

Calisphere public interface source code (UCLDC Project) master branch should match live site
https://calisphere.org/
2 stars 5 forks source link

[to do] frontend updates to label empty "type" & empty "date" values #350

Closed christinklez closed 6 months ago

christinklez commented 6 months ago

This collection has 92 objects that have an empty "type" field:

This is a Nuxeo collection with 5 objects with an empty "type" field:

When you do a sitewide empty search, the frontend is still confused: https://calisphere-stage.cdlib.org/search/?q=

What are our options here?

Ideally, the records do continue to publish through to Calisphere, and perhaps:

christinklez commented 6 months ago

There are actually more records from a variety of collections with an empty type field. This link should get you to it: https://calisphere-stage.cdlib.org/search/?q=&sort=a&type_ss=

(Note that if you go here: https://calisphere-stage.cdlib.org/search/?q= -- the empty type will be visibly checked off, but the results will not reflect that.)

christinklez commented 6 months ago

Discussed that in the frontend, we could potentially update the javascript to display a custom label (something like unknown or not supplied). This would not touch the OpenSearch index.

christinklez commented 6 months ago

An FYI that we now have empty "date" values appearing in the facets: https://calisphere-stage.cdlib.org/search/?q=&sort=a

amywieliczka commented 6 months ago

Dev work on this is complete with #351 but I still need some proper language approvals.

christinklez commented 6 months ago

Thanks @amywieliczka! I see the new "date value not supplied" and "type value not supplied" labels--they both look great, and the functionality of the search/browse pages also look good.

@aturner--let's plan to touch base to discuss the labels. Thanks!

christinklez commented 6 months ago

Closing this work as done! The issue initially reported (frontend being confused by empty values) is resolved, and the dev work to prep to transform the blank values with labels looks good.

Opened a new issue to formalize the label, see #959.

Thanks!