search

ucldc / public_interface

Calisphere public interface source code (UCLDC Project) master branch should match live site
https://calisphere.org/
2 stars 5 forks source link

[bug] Results paging bug for collections with type None items #356

Closed christinklez closed 6 months ago

christinklez commented 6 months ago

To reproduce:

This results in no items displayed and "1 item found in this collection of 66 items" heading.

url: https://calisphere-stage.cdlib.org/collections/469/?q=&sort=a&type_ss=&start=24

This is because we are currently including records with type_ss=None in our faceting query. The "next page" URL includes the type_ss facet, which defaults to no value, and there is only one record with type None in this collection.

christinklez commented 6 months ago

Adding in an example of a collection with date None -- this does not seem to produce the same error. https://calisphere-stage.cdlib.org/collections/26171/

amywieliczka commented 6 months ago

This should be resolved with https://github.com/ucldc/public_interface/pull/351, but let's check once that's merged in.

christinklez commented 6 months ago

Both of these collections (type not supplied & date not supplied) look good on -stage! Also tested out with viewing 24 items & 48 items. Thanks!