search

uclibs / application_portfolio

The application manages applications at UCL
https://libapps.libraries.uc.edu/application_portfolio
2 stars 1 forks source link

Use abilities (refactor) #370

Closed hortongn closed 2 months ago

hortongn commented 3 months ago

Given this application has users with different roles, we should be using the cancancan gem with an Abilities class like our other apps. This will clean up some of the custom logic we have.

scherztc commented 3 months ago

Currently, we use Petergate : https://github.com/elorest/petergate

What does CanCan give us that Petergate doesn't?

hortongn commented 3 months ago

@scherztc The petergate gems hasn't been updated in a few years. Better to use cancancan that has active development. I'm not saying we need to switch now. I'm just creating the issue so we remember to do it at some point.

scherztc commented 2 months ago

Closed by JIRA : https://ucdts.atlassian.net/browse/LIBAPPPORT-32?atlOrigin=eyJpIjoiNjk0YzNiNmFhNTc3NDBmZGI4NTM5MGRmMDlkN2ZlNGIiLCJwIjoiaiJ9