search

uclibs / scholar_uc_legacy

Source code for Scholar@UC up to version 3.x. Replaced by ucrate
Other
5 stars 1 forks source link

Removal of Sharing is incomplete #1026

Closed newmanld closed 7 years ago

newmanld commented 7 years ago

Descriptive summary

As an owner/depositor, I can share a work with others and grant edit access. If I remove this access, the removal is not taking place until the former editor edits the work one more time.

Expected behavior

When I remove edit access from an individual work, the change should take place in a reasonable amount of time. The former editor should not be able to edit the work one more time.

Actual behavior

The former editor still has access to the work that they should no longer be able to edit, until they edit that work one more time (and until that last edit, with or without changes, is saved). I have replicated this three times.

Steps to reproduce the behavior

  1. edit one of your works. Go to the Share tab. Under 'Share work with other users" search for a user, and then under 'Choose Access' select 'Edit.' Save the work.
  2. As the other user (the editor) verify that you can edit the work.
  3. As the submitter, remove the edit access.
  4. As the other user (the former editor), verify that you can still edit the work until you edit the work one more time.

Related testing

Probably wise to also test what happens, on a private or embargoed work, when View/Access is granted and then revoked.

See also #1024. Note that when Proxy access is revoked, the former proxy is left as an editor of works that they submitted.

jamesvanmil commented 7 years ago

@newmanld Did you ever get any other errors when working though this? I'm seeing an LDP::Gone exception now when I'm working to recreate and test with workers running.

It looks like the permission is being deleted successfully in Fedora, but the application is still trying to access it (which produces the LDP::Gone) - an examination of the document in Solr shows that the edit permission is still recorded there, which explains why the editor still has access.

newmanld commented 7 years ago

I don't recall seeing any error messages. I was checking that edit access was appropriately revoked.

hortongn commented 7 years ago

Confirmed the Ldp::Gone bug exists back in Sufia 7.2/Curation Concerns 1.6.3. Going to to dig deeper to see if this is specific to Sufia or is in CC as well. Will file a bug with the appropriate gem.

hortongn commented 7 years ago

The Ldp::Gone error is a bug in hydra-head 10.4.0. Pinning to 10.3.0 for now resolves it.

So that let's us continue work on the original bug removed above.

jamesvanmil commented 7 years ago

Currently blocked by #1137

hortongn commented 7 years ago

I'm still getting the Ldp::Gone error on Sufia 7.3.0.rc1 even with the newest active-fedora. I'll confirm the error again and will then re-open the issue so the community knows.

scherztc commented 7 years ago

Test issue on curly.libraries.uc.edu

hortongn commented 7 years ago

Tested this again now that the LDP::Gone error has been resolves and I verified that this bug has also been resolved (in both Sufia and our app). So marking as closed.

scherztc commented 7 years ago

Size : 4