search

uclibs / scholar_uc_legacy

Source code for Scholar@UC up to version 3.x. Replaced by ucrate
Other
5 stars 1 forks source link

Review current overrides under Sufia 7.3.0.rc1 #1146

Closed hortongn closed 7 years ago

hortongn commented 7 years ago

Review any overrides that we've added to scholar_uc in case the source code has changed between Sufia 7.2.0 and Sufia 7.3.0.rc1

hortongn commented 7 years ago

After we overrode the homepage layout, Sufia changed https://github.com/uclibs/scholar_uc/blob/develop/app/views/layouts/homepage.html.erb#L12 to https://github.com/uclibs/scholar_uc/blob/develop/app/views/layouts/homepage.html.erb#L12

See https://github.com/projecthydra/sufia/commit/fbcdaa76c757c6c79b8010e6ee5901c7cde680ed

hortongn commented 7 years ago

A visual inspection of our app revealed only one place where we have an existing Sufia/CC override that should be tweaked to match current Sufia code. See above content for details. I'll open an issue for that small change just so we stay consistent.

Everything else looks good from what I can see.