search

uclibs / scholar_uc_legacy

Source code for Scholar@UC up to version 3.x. Replaced by ucrate
Other
5 stars 1 forks source link

Fix embedded video viewer #1346

Closed hortongn closed 7 years ago

hortongn commented 7 years ago

For works with attached videos, Scholar displays a viewer on the show page that should allow the user to watch the video. However, the viewer remains blank.

If the viewer can't be easily fixed, disable it (for the beta) from views on the work and file show pages.

Resources

hortongn commented 7 years ago

The video viewer doesn't work because the source of the video in the viewer is specified as /downloads/4m90dv686?file=webm but ActiveFedora doesn't retrieve the video when ?file=webm or ?file=mp4 is appended after the pid. Removing that and using just /downloads/4m90dv686 allows the video to load and play in the viewer (although it's slow since it has to be retrieved from Fedora). Works in all browsers I tested.

Also, we need to pin the viewer to a specific size or it will grow to match the size of a large video and cause problems for the layout. 320x240 works well.

I have fixes for both of these problems and will submit a PR after I do some more testing.

hortongn commented 7 years ago

Undo the changes made in PR #1353. Enable config.enable_ffmpeg in config/initializers/sufia.rb.

Also update ffmpeg on Curly to handle required formats.