search

uclibs / scholar_uc_legacy

Source code for Scholar@UC up to version 3.x. Replaced by ucrate
Other
5 stars 1 forks source link

Display seperate field for work and file views #1905

Closed asleepysheepy closed 6 years ago

asleepysheepy commented 6 years ago

Fixes #1904

Adds work views and an additional field on the user show page

image
hortongn commented 6 years ago

FYI, I've put this code up on scholar-qa. Seems to be working.

See https://scholar-qa.uc.edu/users/vanmiljf@ucmail-dot-uc-dot-edu

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 95.869% when pulling a2df8115f5033665d81b91862d003015bedf2b6c on fix/#1904-seperate-file-work-views into 0f8d7b5bcaa400370c1c4526c84b892ee2884490 on develop.

hortongn commented 6 years ago

@flutterflies I do think we should have specs on this. You can probably whip up a quick view spec based on https://github.com/samvera/hyrax/blob/master/spec/views/hyrax/users/show.html.erb_spec.rb and just verify that it finds the Work Views, File Views, and Downloads badges.

jamesvanmil commented 6 years ago

@hortongn @flutterflies I'm probably not going to have time to review this until Friday if it still needs more work

hortongn commented 6 years ago

@jamesvanmil @flutterflies I can review if you are ok with that. If we can get it in today, we can get on the agenda for Thursday's change request meeting.