uclibs / scholar_uc_legacy

Source code for Scholar@UC up to version 3.x. Replaced by ucrate
Other
5 stars 1 forks source link

Fix facet search when sting contains ampersand #1937

Closed hortongn closed 6 years ago

hortongn commented 6 years ago

Fixes #1926

Overrides the #li_value method in Hyrax's FacetedAttributeRenderer class so that ampersands are properly handled. Without this fix, clicking on a faceted search link on the works show page would yield no results searches with & in them.

The problem was that & was being encoded to & and then to %26amp%3B which is nice for browsers, but solr doesn't understand it. So it now substitutes %26amp%3B for just %26 which solr interprets as &

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.01%) to 95.911% when pulling 9ef34ca2d2d8384b38ec419cd2e7708f5fffb448 on bug/#1926-ampersand-breaks-facet into e51e5f96b816431d84a28cbe27e1d2a34f41f895 on develop.