search

uclibs / scholar_uc_legacy

Source code for Scholar@UC up to version 3.x. Replaced by ucrate
Other
5 stars 1 forks source link

Proxy submitters not removed from work when proxy is removed from account #1944

Closed jamesvanmil closed 6 years ago

jamesvanmil commented 6 years ago

Actual behavior

After directing a user to remove a user as his proxy (and confirming that he did it), I confirmed that the proxy is still an #edit_user on works and file_set

Desired behavior

When a proxy is removed, their access is removed from works that they submitted, and the associated file_sets

To replicate

  1. create two users and and assign one as a proxy of the other
  2. have the proxy assign a work
  3. remove the proxy relationship
  4. check that the user has been removed as an editor
jamesvanmil commented 6 years ago

https://github.com/uclibs/scholar_uc/blob/develop/app/jobs/proxy_edit_removal_job.rb

jamesvanmil commented 6 years ago

The job isn't working because work.on_behalf_of = nil for these works.

jamesvanmil commented 6 years ago

Cleaning up the access now - will open a new issue for the job not working.