uclibs / scholar_uc_legacy

Source code for Scholar@UC up to version 3.x. Replaced by ucrate
Other
5 stars 1 forks source link

Virus scanning not working properly #1949

Closed hortongn closed 5 years ago

hortongn commented 6 years ago

Descriptive summary

It looks like Scholar is not behaving the way we would expect when someone tries to upload an infected file.

Expected behavior

Scholar should alert the user via a flash message and drop the infected file instead of attaching it to the work.

Actual behavior

Scholar creates the work and attaches a file set like it would for a normal file. However, it looks like the file set may not contain a file. Trying to download the infected file gives a 404. So Scholar is not displaying a flash message and is creating a file set, but it does look like the actual infected file is being blocked from Fedora.

We used the typical EICAR test virus file to test this.

Commit that implemented virus scanning: https://github.com/uclibs/scholar_uc/commit/8161ecfdb278b91c93390ca74c38680f288f3496

It's possible that Hydra::Works::VirusCheckerService has had a new release since we implemented virus scanning and that external code broke something.

crowesn commented 6 years ago

from ucrate https://github.com/uclibs/ucrate/commit/4cce3b07445ebf97ba96713ae4b23970c9d1b92c