search

uclibs / staff-directory-23

1 stars 0 forks source link

144 - Update Ruby to 3.3.0 #153

Closed haitzlm closed 7 months ago

haitzlm commented 7 months ago

Fixes #144 was able to deploy this successfully once, then whenever I try to do anything, I get "Your Ruby version is 3.2.2, but your Gemfile specified 3.3.0 "

And of course, my gemfile does NOT say that. Will work through.

Janell-Huyck commented 7 months ago

Looks like it just needs a rubocop fix atm. The changes look like they should work. :)

haitzlm commented 7 months ago

Done and pushed!

Lisa Haitz Software Developer 3 Application Development Unit DTS: UC Libraries IT University of Cincinnati 513-556-1431 @.**@.> She/her/hers

From: Janell Huyck @.> Date: Monday, April 1, 2024 at 12:48 PM To: uclibs/staff-directory-23 @.> Cc: Haitz, Lisa (haitzlm) @.>, Author @.> Subject: Re: [uclibs/staff-directory-23] WIP: Updateruby (PR #153)

External Email: Use Caution

Looks like it just needs a rubocop fix atm. The changes look like they should work. :)

— Reply to this email directly, view it on GitHubhttps://github.com/uclibs/staff-directory-23/pull/153#issuecomment-2030138067, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADYQVUCYP2MUU3BJ7WQQRLY3GFUFAVCNFSM6AAAAABFO6M426VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGEZTQMBWG4. You are receiving this because you authored the thread.Message ID: @.***>

haitzlm commented 7 months ago

I rebased and ran brakeman, rpsec and rubocop, but i have not redone the database, if that is necessary.