search

uclibs / treatment_database

Application to track conservation workflow for Preservation Services
1 stars 2 forks source link

Decommission wkhtmltopdf_binary fork #500

Closed crowesn closed 4 months ago

crowesn commented 4 months ago

Resolves #496

Recent release of wkhtmltopdf_binary gem includes fix to accommodate oracle linux. We created a forked repo with PR to the parent that was accepted in most recent release, we can now decommission our fork.

crowesn commented 4 months ago

I think we'll want to test this on QA before merging.

Janell-Huyck commented 4 months ago

On Libappstest, for the "Reports" section, the report that was generated last month isn't showing up correctly.

Screenshot 2024-05-16 at 2 38 24 PM

The report that I generated today is working fine.

Screenshot 2024-05-16 at 2 38 38 PM

My question is... is this expected behavior? I've never tried to view an old report before. Did changing from our forked version of the gem to the regular version cause the old reports to not work anymore? The newly generated report is downloadable. Is the Conservation Lab group okay with this? Do they need access to the old reports?

Janell-Huyck commented 4 months ago

Sean confirmed that this is present on production already so not a new bug. Merging.