Configure docker to run on curly / sandbox

uclibs / uc_drc

DRC migration planning and work

Other

0 stars 0 forks source link

Configure docker to run on curly / sandbox #94

Closed crowesn closed 3 years ago

crowesn commented 3 years ago

Fixes #74

Changes proposed in this pull request:

Move docker config to app root directory
De-commission hyrax-docker submodule
Update docker-compile.yml to run both on local and curly.libraries.uc.edu
Add dot-env variables for curly.libraries.uc.edu
Update readme

crowesn commented 3 years ago

@hortongn @scherztc

This should be ready to go - I'd like to get this merged before the bulkrax/Alison flex if possible, so that we can use docker to stage those branches on Curly.

crowesn commented 3 years ago

This is running on http://curly.libraries.uc.edu:3010.

crowesn commented 3 years ago

Yes I think we can do that - would you like that in this PR or shall I open another issue?

hortongn commented 3 years ago

I'll finish reviewing the PR and will let you know. We can probably make the solr/config thing a new issue, but let me see if other changes are needed.

hortongn commented 3 years ago

@crowesn Oh yeah, 2 things about the README (these can be a separate PR if you want):

I had to use docker logs not docker log to view a container's log
Is there a way to run the specs using docker? If so, we should add that command to the README. We might be able to simplify our CI config if specs can all be run in docker.

crowesn commented 3 years ago

I’ll update the docker logs typo.
It’s not currently setup to run specs but it can be. I’ll open an issue for this.