uclibs / ucrate

Scholar@UC: University of Cincinnati's self-submission institutional repository
https://scholar.uc.edu
Other
5 stars 3 forks source link

Fixes universal_viewer deprecation. #1083

Closed scherztc closed 11 months ago

scherztc commented 11 months ago

Fixes #987 Fixes #893

Present short summary (50 characters or less)

This fixes the universal_viewer deprecation in our show overwrite.

To test you should be able run the test suite without any warnings. To test you should be able to ingest an Image Work with a jpg and see the jpg in viewer.

Changes proposed in this pull request:

crowesn commented 11 months ago

@scherztc Needs rebase over develop for ruby-2.7.8

hortongn commented 11 months ago

I'm removing myself as a reviewer on this PR. The tests pass and the deprcation message is gone, but I can't test that the image viewer still works because I can't get technical metadata in my local environment.

So someone needs to make sure the image viewer still shows up in this branch.