Janell-Huyck
commented
8 months ago Develop Branch:
Coverage report generated for RSpec to /Users/huyckjl/Codebases/ucrate/coverage. 3200 / 3372 LOC (94.9%) covered. Lcov style coverage report generated for RSpec to /Users/huyckjl/Codebases/ucrate/coverage/lcov/ucrate.lcov [Coveralls] Outside the CI environment, not sending data. [Coveralls] Some handy coverage stats:
- app/actors/hyrax/actors/article_actor.rb => 100%
- app/actors/hyrax/actors/dataset_actor.rb => 100%
- app/actors/hyrax/actors/document_actor.rb => 100%
- app/actors/hyrax/actors/etd_actor.rb => 100%
- app/actors/hyrax/actors/generic_work_actor.rb => 100%
- app/actors/hyrax/actors/image_actor.rb => 100%
- app/actors/hyrax/actors/medium_actor.rb => 100%
- app/actors/hyrax/actors/mint_doi_actor.rb => 100%
- app/actors/hyrax/actors/student_work_actor.rb => 100%
- app/api/scholar/api.rb => 100%
- app/api/scholar/shared_params.rb => 97%
- app/api/scholar/v1/collections.rb => 95%
- app/api/scholar/v1/concern.rb => 95%
- app/api/scholar/v1/users.rb => 92%
- app/channels/application_cable/channel.rb => 100%
- app/channels/application_cable/connection.rb => 100%
- app/controllers/api_uploads_controller.rb => 0%
- app/controllers/application_controller.rb => 100%
- app/controllers/bulkrax/exporters_controller.rb => 100%
- app/controllers/bulkrax/importers_controller.rb => 100%
- app/controllers/callbacks_controller.rb => 100%
- app/controllers/catalog_controller.rb => 100%
- app/controllers/classify_concerns_controller.rb => 84%
- app/controllers/collection_exports_controller.rb => 89%
- app/controllers/common_objects_controller.rb => 100%
- app/controllers/concerns/hyrax/controller.rb => 100%
- app/controllers/concerns/hyrax/works_controller_behavior.rb => 100%
- app/controllers/concerns/scholar/works_controller_behavior.rb => 100%
- app/controllers/devise/passwords_controller.rb => 100%
- app/controllers/display_users_controller.rb => 100%
- app/controllers/errors_controller.rb => 100%
- app/controllers/featured_collections_controller.rb => 57%
- app/controllers/feed_controller.rb => 100%
- app/controllers/hyrax/articles_controller.rb => 100%
- app/controllers/hyrax/batch_uploads_controller.rb => 100%
- app/controllers/hyrax/collections_controller.rb => 100%
- app/controllers/hyrax/dashboard/collections_controller.rb => 100%
- app/controllers/hyrax/dashboard/profiles_controller.rb => 100%
- app/controllers/hyrax/datasets_controller.rb => 100%
- app/controllers/hyrax/depositors_controller.rb => 97%
- app/controllers/hyrax/documents_controller.rb => 100%
- app/controllers/hyrax/etds_controller.rb => 100%
- app/controllers/hyrax/file_sets_controller.rb => 100%
- app/controllers/hyrax/generic_works_controller.rb => 100%
- app/controllers/hyrax/images_controller.rb => 100%
- app/controllers/hyrax/media_controller.rb => 100%
- app/controllers/hyrax/student_works_controller.rb => 100%
- app/controllers/hyrax/uploads_controller.rb => 100%
- app/controllers/hyrax/users_controller.rb => 100%
- app/controllers/registrations_controller.rb => 100%
- app/controllers/sitemaps_controller.rb => 100%
- app/controllers/static_controller.rb => 97%
- app/controllers/welcome_page_controller.rb => 100%
- app/forms/hyrax/article_form.rb => 100%
- app/forms/hyrax/dataset_form.rb => 100%
- app/forms/hyrax/document_form.rb => 100%
- app/forms/hyrax/etd_form.rb => 100%
- app/forms/hyrax/forms/batch_edit_form.rb => 100%
- app/forms/hyrax/forms/batch_upload_form.rb => 94%
- app/forms/hyrax/forms/collection_form.rb => 100%
- app/forms/hyrax/generic_work_form.rb => 100%
- app/forms/hyrax/image_form.rb => 100%
- app/forms/hyrax/medium_form.rb => 100%
- app/forms/hyrax/student_work_form.rb => 100%
- app/helpers/api_helper.rb => 76%
- app/helpers/application_helper.rb => 100%
- app/helpers/change_manager/change_manager_helper.rb => 97%
- app/helpers/collection_export_helper.rb => 100%
- app/helpers/feed_helper.rb => 100%
- app/helpers/hyrax_helper.rb => 100%
- app/helpers/mark_helper.rb => 95%
- app/helpers/show_welcome_helper.rb => 100%
- app/helpers/works_helper.rb => 100%
- app/indexers/article_indexer.rb => 100%
- app/indexers/dataset_indexer.rb => 100%
- app/indexers/document_indexer.rb => 100%
- app/indexers/etd_indexer.rb => 100%
- app/indexers/generic_work_indexer.rb => 100%
- app/indexers/hyrax/collection_indexer.rb => 100%
- app/indexers/hyrax/work_indexer.rb => 100%
- app/indexers/image_indexer.rb => 100%
- app/indexers/medium_indexer.rb => 100%
- app/indexers/sortable_title_indexer.rb => 100%
- app/indexers/student_work_indexer.rb => 100%
- app/jobs/application_job.rb => 100%
- app/jobs/attach_files_to_work_job.rb => 96%
- app/jobs/batch_create_job.rb => 100%
- app/jobs/change_manager/process_change_job.rb => 100%
- app/jobs/fixity_check_job.rb => 100%
- app/jobs/identifier_delete_job.rb => 89%
- app/jobs/identifier_embargo_update_job.rb => 100%
- app/jobs/proxy_edit_removal_job.rb => 100%
- app/jobs/user_edit_profile_event_job.rb => 100%
- app/mailers/application_mailer.rb => 100%
- app/mailers/change_manager/scholar_notification_mailer.rb => 100%
- app/mailers/embargo_mailer.rb => 100%
- app/mailers/fixity_mailer.rb => 100%
- app/mailers/welcome_mailer.rb => 100%
- app/models/ability.rb => 100%
- app/models/application_record.rb => 100%
- app/models/article.rb => 97%
- app/models/basic_collection_metadata.rb => 100%
- app/models/batch_upload_item.rb => 91%
- app/models/classify_concern.rb => 95%
- app/models/collection.rb => 92%
- app/models/collection_export.rb => 100%
- app/models/concerns/bulkrax/has_local_processing.rb => 100%
- app/models/concerns/change_manager/comparison_concern.rb => 100%
- app/models/concerns/hydra/access_controls/visibility.rb => 100%
- app/models/concerns/hyrax/basic_metadata.rb => 100%
- app/models/concerns/hyrax/collections/featured.rb => 100%
- app/models/concerns/remotely_identified_by_doi.rb => 98%
- app/models/concerns/remove_proxy_editors.rb => 100%
- app/models/dataset.rb => 97%
- app/models/document.rb => 97%
- app/models/etd.rb => 98%
- app/models/featured_collection.rb => 92%
- app/models/file_set.rb => 100%
- app/models/generic_work.rb => 97%
- app/models/hydra/access_controls/permission.rb => 90%
- app/models/hyrax/statistic.rb => 80%
- app/models/hyrax/uploaded_file.rb => 100%
- app/models/hyrax/virus_scanner.rb => 100%
- app/models/image.rb => 97%
- app/models/medium.rb => 97%
- app/models/qa.rb => 0%
- app/models/qa/local_authority.rb => 100%
- app/models/qa/local_authority_entry.rb => 100%
- app/models/search_builder.rb => 100%
- app/models/solr_document.rb => 97%
- app/models/student_work.rb => 97%
- app/models/user.rb => 100%
- app/models/work_and_file_index.rb => 100%
- app/presenters/hyrax/article_presenter.rb => 100%
- app/presenters/hyrax/collection_presenter.rb => 90%
- app/presenters/hyrax/dataset_presenter.rb => 100%
- app/presenters/hyrax/document_presenter.rb => 100%
- app/presenters/hyrax/etd_presenter.rb => 100%
- app/presenters/hyrax/generic_work_presenter.rb => 100%
- app/presenters/hyrax/image_presenter.rb => 100%
- app/presenters/hyrax/medium_presenter.rb => 100%
- app/presenters/hyrax/presents_attributes.rb => 100%
- app/presenters/hyrax/student_work_presenter.rb => 100%
- app/presenters/permalinks_presenter.rb => 100%
- app/renderers/hyrax/renderers/attribute_renderer.rb => 100%
- app/renderers/hyrax/renderers/note_renderer.rb => 89%
- app/services/change_manager/email_manager.rb => 100%
- app/services/collection_loader.rb => 91%
- app/services/collection_metadata_csv_factory.rb => 100%
- app/services/collections_report.rb => 100%
- app/services/expiration_service.rb => 100%
- app/services/files_report.rb => 100%
- app/services/hyrax/analytics.rb => 85%
- app/services/hyrax/change_content_depositor_service.rb => 100%
- app/services/hyrax/custom_stat_importer.rb => 71%
- app/services/hyrax/default_middleware_stack.rb => 100%
- app/services/hyrax/fixity_check_failure_service.rb => 100%
- app/services/hyrax/user_stat_adder.rb => 100%
- app/services/parent_query_service.rb => 100%
- app/services/pids_out.rb => 0%
- app/services/report.rb => 95%
- app/services/rss_query_handler.rb => 100%
- app/services/users_report.rb => 100%
- app/services/work_loader.rb => 91%
- app/services/work_metadata_attribute_mapper.rb => 100%
- app/services/works_report.rb => 100%
- app/services/works_resave.rb => 0%
- lib/active_fedora/fedora.rb => 96%
- lib/scholar.rb => 100%
- lib/tasks/embargo_notify.rake => 100%
- lib/tasks/embargo_release.rake => 83%
scherztc
Fixes #1075
Fix warning message for "Unused parameters passed to Capybara."
Capybara tests can have things like .have_link("some text", {optional parameters}). The optional parameters need to be one of the following:
:count, :minimum, :maximum, :between, :text, :id, :class, :visible, :exact, :exact_text, :match, :wait, :filter_set, :href, :title, :altWe had tests that were looking like this:
expect(page).to have_link('use the contact page', contact_path), where we were not specifying what that second parameter was. Not specifying meant that the second parameter wasn't being tested, and was raising that warning message "unused parameters passed to Capybara."This PR is to fix that warning message by clarifying what the second parameter passed in several tests is supposed to be.
We have to pass in the
localeas "en" because the actual url for the above example was not/contactbut rather/contact?locale=en. This PR factored out the locale into a let :variable at the start of the spec/features/uc_shibboleth_spec.rb file because it was needed in multiple locations in the tests.