uclibs / ucrate

Scholar@UC: University of Cincinnati's self-submission institutional repository
https://scholar.uc.edu
Other
5 stars 3 forks source link

1075 Fix Capybara warning for "Files", discover failing test #1120

Closed Janell-Huyck closed 7 months ago

Janell-Huyck commented 8 months ago

Fixes #1075

See PR #1108 for more information about the Capybara warnings.

There was a Capybara warning for Unused parameters passed to Capybara::Queries::SelectorQuery : ["Files"]. This came from the test at spec/features/form_tab_nav_js_spec.rb:30 that had a parameter "Files" in the have_selector() call. The lack of keyword "text:" caused this parameter to not be used, so the test was only looking for the first item in the query, an active list item.

Adding in the keyword "text:" causes the test to fail because the desired behavior is not happening.

I skipped the test because it will not pass without fixing the bug, and have created an issue for the bug, Ref #1121