uclibs / ucrate

Scholar@UC: University of Cincinnati's self-submission institutional repository
https://scholar.uc.edu
Other
5 stars 3 forks source link

Fix Failing Test after Hyrax Upgrade #1131

Open scherztc opened 9 months ago

scherztc commented 9 months ago

Descriptive summary

Expected behavior

Actual behavior

Steps to reproduce the behavior

  1. Do this
  2. Then do this...

Related work

Link to related issues or prior related work here.

Janell-Huyck commented 9 months ago

This error also shows upon trying to launch Scholar locally. I looked for and did not find a partial named "ga" or "_ga".

Janell-Huyck commented 9 months ago

1135 may not actually be an error - it is failing in an after-do block trying to clean up after a test. It tries to destroy a User that is not actually created due to an error inside the tests. It ties back into this error:

RSpec::Core::MultipleExceptionError: Error: "calc(100vh - 110px)" is not a number for `min'
        on line 1:30625 of stdin, in function `min`
        from line 1:30625 of stdin
>> x;flex:1;flex-direction:column;max-height:min(650px,calc(100vh - 110px));ove

This "calc" error seems to be triggered with images - it is caused by the logo and by the image_tag calls in a partial.