uclnlp / inferbeddings

Injecting Background Knowledge in Neural Models via Adversarial Set Regularisation
MIT License
59 stars 12 forks source link

Adapt Algorithm to new formulation #16

Closed riedelcastro closed 7 years ago

riedelcastro commented 7 years ago

I copied over the algorithm environment from the old version. Needs adaptation.

This would also include generalise the "entity normalisation" step, which may use unit-ball, unit box, or nothing at all (and instead rely on regularisation). We can also not generalise, and then explicitly say in the text body that other mechanisms are possible but we stick to one for simplicity of exposition.

pminervini commented 7 years ago

@riedelcastro does an assumption $A$ (now macro-ed with $\Ass$ in the TeX) correspond to a set of clauses, or just a single clause ?

riedelcastro commented 7 years ago

A single clause. I chose to do this because I wanted to avoid further clutter, and because extensions to multiple clauses are trivial (it just means you need to throw in \sums and indices everywhere). But feel free to change this if you like to make it more explicit.

S

On 21 Feb 2017, at 22:35, Pasquale Minervini notifications@github.com wrote:

@riedelcastro https://github.com/riedelcastro does an assumption $A$ correspond to a set of clauses, or just a single clause ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uclmr/inferbeddings/issues/16#issuecomment-281504785, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKMzBo2vKi4EtEq6u76L0r2bSeuIqJeks5re2bOgaJpZM4MG_qw.

pminervini commented 7 years ago

No, it was just to make sure - I agree that the single-clause formulation is much more readable, and it's trivial to extend