search

uclnlp / jack

Jack the Reader
MIT License
257 stars 82 forks source link

Check all notebooks #258

Closed dirkweissenborn closed 6 years ago

dirkweissenborn commented 7 years ago

Check Notebooks (test them, more documentation)

pminervini commented 6 years ago

I'm on it - currently trying to fix https://github.com/uclmr/jack/blob/master/notebooks/Implementing_a_new_model.ipynb

pminervini commented 6 years ago

I'm getting an error at the following line at SNLI.ipynb:

reader.output_module = MisclassificationOutputModule(interval=[0.0, 0.20], limit=10)

The error is AttributeError: can't set attribute: @dirkweissenborn can you fix it?

riedelcastro commented 6 years ago

On that note: do we really need a MisclassificationOutputModule? I think output modules should simply transform the model predictions to usable python Answer objects. Misclassification calculation etc. should happen outside of it. Maybe this is easier to fix just in that way?

pminervini commented 6 years ago

All notebooks should be fine now.

(I'll add a test case for each of them)