search

uclnlp / jack

Jack the Reader
MIT License
257 stars 82 forks source link

Remove unused code #289

Closed pminervini closed 6 years ago

pminervini commented 6 years ago

I was going through the code, and noticed a few functions that are not invoked anywhere in the code - for example get_feed_dicts in ./jack/util/batch.py. Can I just remove them safely?

pminervini commented 6 years ago

@dirkweissenborn, @undwie, what do you think ?

undwie commented 6 years ago

Totally!

TimDettmers commented 6 years ago

I would establish the policy where these things are always deleted. Unused code has no place in the master. If someone misses the delted code they can always fetch it from a previous state. Does that make sense?