search

uclnlp / jack

Jack the Reader
MIT License
257 stars 82 forks source link

Ensure all models use Answer.span and Answer.doc_idx correctly #295

Closed georgwiese closed 6 years ago

georgwiese commented 6 years ago

Currently, some models use Answer.span = (doc_idx, start, end), while it would be correct to use Answer.span = (start, end) and Answer.doc_idx.

georgwiese commented 6 years ago

Never mind, there was only one occurrence in a test, fixed on fastqa_answer_spans.