search

uclnlp / jack

Jack the Reader
MIT License
257 stars 82 forks source link

installation for gpu #305

Closed dirkweissenborn closed 6 years ago

dirkweissenborn commented 6 years ago

it would be nice to have an setup procedure for cuda based installations. For instance, the tensorflow the requirements would have to change to tensorflow-gpu.

pminervini commented 6 years ago

I'll do something like https://github.com/tensorflow/tensor2tensor/blob/master/setup.py, so it will be possible to do e.g. pip install jack[gpu]

dirkweissenborn commented 6 years ago

awesome

TimDettmers commented 6 years ago

It is currently not possible to install jack without TensorFlow CPU. If I only have TensorFlow GPU the install fails.

pminervini commented 6 years ago

This looks like the proper way of handling the issue:

https://github.com/tensorflow/tensor2tensor/blob/master/setup.py#L37

pminervini commented 6 years ago

https://github.com/uclmr/jack/pull/349