search

uclnlp / jack

Jack the Reader
MIT License
257 stars 82 forks source link

SQuAD data download does not work properly #308

Closed TimDettmers closed 6 years ago

TimDettmers commented 6 years ago

It copies it to the wrong directory (main directory). I do not know if there are other dependency problems.

dirkweissenborn commented 6 years ago

@TimDettmers I don't understand. Following the readme you download it in the SQuAD directory. However, I see your point. Feel free to change it such that you do not have to cd into the SQuAD directory first.

TimDettmers commented 6 years ago

Currently, it is download into the current directory rather than the data/SQuAD directory which make subsequent scripts fail.

dirkweissenborn commented 6 years ago

Please look at the README where it is stated that you have to cd into the SQuAD dir and download from there so it is not wrong, only inconvenient, we should change that. The same goes for GloVe for instance.