Test for jack.readers.implementations.reader_from_file

uclnlp / jack

Jack the Reader

MIT License

258 stars 82 forks source link

Test for jack.readers.implementations.reader_from_file #369

Closed dirkweissenborn closed 6 years ago

dirkweissenborn commented 6 years ago

We need a test that:

creates all our defined readers
saves them
and laods them with reader_from_file

pminervini commented 6 years ago

Like this? https://github.com/uclmr/jack/blob/fix-369/tests/jack/readers/test_serialization.py

dirkweissenborn commented 6 years ago

yeah, but it won't work unfortunately, because we need some configuration for these models and these might differ between the readers, so I guess it is a bit more tricky than that...

dirkweissenborn commented 6 years ago

I think having a couple of examples should be enough. The ones for which we have test configs for instance