Solution implementation to Cp 378

ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.

Apache License 2.0

78 stars 34 forks source link

Solution implementation to Cp 378 #385

Closed plbt5 closed 2 years ago

plbt5 commented 2 years ago

This Pull Request resolves all ontology requirements of Issue #378 . For the documentation requirement, refer to ucoproject.github.io's PR 41

Review steps taken:

[x] Pull request is against correct branch
[x] CI passes in (CASE/UCO) feature branch
[x] CI passes in (CASE/UCO) current unstable branch (merge-commit)
[x] Impact on SHACL validation reviewed for CASE-Examples
[x] Impact on SHACL validation remediated for CASE-Examples (N/A)
[x] Impact on SHACL validation reviewed for casework.github.io
[x] Impact on SHACL validation remediated for casework.github.io (N/A)

plbt5 commented 2 years ago

@ajnelson-nist I was able to throw a normalisation error by only ading one single triple statement duh. I'm not sure how to proceed.

ajnelson-nist commented 2 years ago

This was filed against master, not develop. Can you update the PR's target to develop? (It'd be nice if we could configure this repository to set that as the default...)

Also, about normalization - that statement needs to be inlined into the core:Object triples block.

ajnelson-nist commented 2 years ago

@plbt5 , can you please adjust this PR to point to develop instead of master, and to normalize its change? Running make check will show you what needs fixing.

plbt5 commented 2 years ago

Wow, changing the base branch from master to develop for this PR was really simple. Learned a thing again 👍

plbt5 commented 2 years ago

Wow, the change to normalise the code took hours. Not because the change itself was possible, but because I combined git local and global changes, and had a hard time to return from the mess I created with that. Remind me to never, ever, combine local and global git changes anymore.

@ajnelson-nist : Anyway, it's done now. You can merge this one now.